-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for XipCS1 pin function. #873
Conversation
Hey @thejpster let me know if there is anything else you would like to be changed or if you would like to wait until rp-rs/rp235x-pac#7 gets addressed. thanks |
Looks ok. I'd like to try it though. Do you have an example? |
I am not sure how to test it without a Pimoroni Pico Plus 2. I use this functionality on my project to enable its PSRAM. https://github.com/Altaflux/gb-rp2350/blob/main/src/main.rs#L375 If you have a Pimoroni Pico Plus 2 I am more than happy to build a sample project for the PSRAM only for you to test if you want to. |
I do. I used it to run the Neotron OS demo at RustConf, as it happens. |
@thejpster sorry for the delay, got caught up with other work. |
The LED is blinking away! Gosh I wish we had probe-rs and defmt working though. |
Implement support for XipCS1 pin function which is necessary to implement support for external ram or flash.
Note: The rp235x-pac is missing function select definition for XipCS1:
https://github.com/rp-rs/rp235x-pac/blob/main/svd/RP2350.yaml#L321
But
FUNCSEL_A::GPCK
has the same value (9). We should add a variant specific for XipCS1.