Check for diagnostic messages on stderr, not stdout #1540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rpm-software-management/dnf5#1641.
Adds support for the
<REPOSYNC>
shorthand toThen stderr is
andThen stderr matches line by line
.Introduces
Then stdout contains lines matching
andThen stderr contains lines matching
steps which are similar toThen stdout contains lines
but treat each expected line as a regex, likeThen stdout matches line by line
.This patchset strengthens many tests; there were many instances of the pattern:
that were replaced with
so now stderr is checked in many places where it wasn't before.
However, some tests were weakened, notably those following the pattern:
Because stderr now includes lots of other (non-error) information including progress bars for downloads and RPM transactions, these occurrences were changed to:
We could maybe make
<RPMDOWNLOAD>
and<RPMTRANSACTION>
markers that work similar to<REPOSYNC>
to allow us to useThen stderr is
again, but I'd rather do that in a follow-up issue.These changes were made mostly manually with the help of Neovim macros.