needs-restarting: Add --exclude-services #556
Conversation
evan-goode
force-pushed
the
evan-goode/needs-restarting-not-services
branch
from
cb57c07
to
1cd6d32
Compare
|
@martinpitt would you mind reviewing this to see whether it would work for you? |
There was a problem hiding this comment.
Thanks @evan-goode ! This looks correct and provides what we need for dnf4.
|
Hmm, I guess our ci-dnf-stack test suite is not really prepared to test this functionality (it doesn't test |
For consumers of `dnf4 needs-restarting`'s output, it's useful to separate the systemd services needing restart vs. the processes not managed by systemd that need restarting. This new `dnf4 needs-restarting --exclude-services` ONLY prints information about processes NOT managed by systemd, and for listing systemd services that need to be restarted, the existing `--services` flag can be used. When both `--services` and `--exclude-services` are passed `--exclude-services` is ignored. For https://issues.redhat.com/browse/RHEL-56137.
evan-goode
force-pushed
the
evan-goode/needs-restarting-not-services
branch
from
e05dff9
to
6977682
Compare
| if not self.opts.exclude_services: | ||
| stale_pids.add(pid) |
There was a problem hiding this comment.
I didn't realize this before but now that the --services option prints only stale_service_names there is no point in adding to the stale_pids when --services is set right?
There was a problem hiding this comment.
I suppose, but I think it's fine to leave it.
|
The PR has been tested downstream in RHEL, everything passed. |
|
The PR has also been tested in Fedora40, everything passed. I'd say it's possible to merge the PR. |
For consumers of
dnf4 needs-restarting's output, it's useful to separate the systemd services needing restart vs. the processes not managed by systemd that need restarting. This newdnf4 needs-restarting --exclude-servicesONLY prints information about processes NOT managed by systemd, and for listing systemd services that need to be restarted, the existing--servicesflag can be used.When both
--servicesand--exclude-servicesare passed--exclude-servicesis ignored.For https://issues.redhat.com/browse/RHEL-56137.
CI PR on the way.