-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend a plugin to resolve expired GPG keys #2166
base: master
Are you sure you want to change the base?
Recommend a plugin to resolve expired GPG keys #2166
Conversation
I wanted to kick this off. We can figure out a better error message or a better place in the code here. The output now looks like this:
|
dnf/cli/cli.py
Outdated
@@ -312,6 +312,8 @@ def gpgsigcheck(self, pkgs): | |||
if error_messages: | |||
for msg in error_messages: | |||
logger.critical(msg) | |||
logger.info("\nUse the `--enableplugin=expired-pgp-keys' " | |||
"paremeter to resolve the problem.\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you :-)
6cf18a7
to
3516532
Compare
bump |
When PGP key for a repository is installed, but already expired, suggest enabling the expired-pgp-keys plugin to reimport the new key and resolve the issue.
Hey @FrostyX, sorry for late response, I've tried to improve the proposed behavior a bit. It's mainly about narrowing the cases when the suggestion message is shown and also a slight modification of the message. Please check it and I can then adjust the commits to the final state. |
Fix #2156