Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not export internal symbols in shared object files #1307

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Do not export internal symbols in shared object files #1307

merged 9 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. libdnf5: API: Do not use inline methods to call private methods 

    Symbols for private methods will be hidden (not exported).
    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    46c5875 View commit details
    Browse the repository at this point in the history

  2. libdnf5: Define macros for assigning symbol visibility 

    The goal is to explicitly set the visibility of symbols using these macros.
And switch the default visibility of symbols to "hidden".
    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1605f10 View commit details
    Browse the repository at this point in the history

  3. libdnf5 library, libdnf5 plugins: Do not export private symbols

    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ca456a0 View commit details
    Browse the repository at this point in the history

  4. Disable libdnf5, libdnf5-cli, dnf5 cpr_plugin C++ unit tests 

    Temporarily disabled. They need private symbols.
    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    deb0245 View commit details
    Browse the repository at this point in the history

  5. libdnf5-cli: Define macros for assigning symbol visibility

    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3b0f713 View commit details
    Browse the repository at this point in the history

  6. libdnf5-cli library: Do not export private symbols

    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9638855 View commit details
    Browse the repository at this point in the history

  7. dnf5: Define macros for assigning symbol visibility

    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e21bd20 View commit details
    Browse the repository at this point in the history

  8. dnf5 app, dnf5 plugins: Do not export private symbols

    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    929760e View commit details
    Browse the repository at this point in the history

  9. Do not export symbols from private "/common/utils" 

    Libraries and applications (libdnf5.so, dnf5, dnf5daemon-client...) use
(and statically link) private utilities from "/common/utils".
And they also publicly export the symbols of these private utilities.

This modification hides the symbols of utilities linked from
"/common/utils".
    @jrohel
    jrohel committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7a86447 View commit details
    Browse the repository at this point in the history