Implementation of unified privileges checking for CLI commands #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop from `clean` command as it is not transactional and add it to `builddep`.
The functionality is needed by both the library and the dnf5 app.
jan-kolarik
force-pushed
the
jkolarik/superuser-privileges-checking
branch
from
476c48b
to
576363c
Compare
|
Actually, I think adding some suffix to the lock file path will be needed in case of testing the write privileges. That would still test the write access in the same directory, but not touching the existing transaction file potentially created by the concurrent dnf instance ... EDIT: Done. |
A single checkpoint was implemented after parsing command-line data but before downloading metadata and processing commands, ensuring unified handling of cases where commands are executed under insufficient privileges.
jan-kolarik
force-pushed
the
jkolarik/superuser-privileges-checking
branch
from
576363c
to
8bd3e2b
Compare
|
/packit copr-build |
jan-kolarik
force-pushed
the
jkolarik/superuser-privileges-checking
branch
from
8bd3e2b
to
06a0aa0
Compare
|
I am creating a new PR (#1505) to address this as the Packit Copr repo is broken due to previous additional fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the existing RPM lock file functionality.
There are a hard-coded list of commands that are not allowed to run without superuser privileges. Then
assumenoanddownloadonlyoptions are taken into account. Lastly, we check if provided command has defined thestoreoption which should be defined for all transactional commands and therefore it should mean a need for elevated privileges.For: #849.