Build libdnf5 static library, re-enable unit tests that use hidden (private) libdnf5 symbols #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
force-pushed
the
fix_disabled_unittests
branch
2 times, most recently
from
e71d6d2
to
2ada044
Compare
jrohel
force-pushed
the
fix_disabled_unittests
branch
from
2ada044
to
c762622
Compare
Some unit tests use private symbols that are not exported from libdnf5.so shared library.
jrohel
force-pushed
the
fix_disabled_unittests
branch
from
c762622
to
8a97400
Compare
jan-kolarik
approved these changes
Jun 10, 2024
|
I am merging this, although CI is broken now. It seems to be due to previous issues in Packit buildroot in combination with race during merging history undo PR and this one. Let's see and eventually fix the issues right in the subsequent PR. |
Merged
via the queue into
rpm-software-management:main
with commit Jun 10, 2024
4a729aa
2 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests use private symbols that are not exported from libdnf5.so shared library.
Therefore, a static version of the libdnf5 library is built in which all symbols are available. Unit tests that need private symbols use the static library.
Please merge after #1307 .