builddep: Support the --with/--without options to toggle bconds #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Sorry about the delay, this looks good, thank you!
Can you fix the formatting issue detected by the Pre Commit Hooks? You can see the specific problem here in the Details.
I have also created a CI update to fix the failing test and add a couple of new ones: rpm-software-management/ci-dnf-stack#1534
This adds the same options used by rpmbuild, mock, etc. for setting macros to flip build-time conditional switches when parsing spec files. It provides a consistent interface across related tools.
|
Okay, thanks, I updated and rebased it. |
Merged
via the queue into
rpm-software-management:main
with commit Aug 6, 2024
62b8ffb
13 of 16 checks passed
kontura
added a commit
to kontura/ci-dnf-stack
that referenced
this pull request
Aug 6, 2024
kontura
added a commit
to rpm-software-management/ci-dnf-stack
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same options used by
rpmbuild,mock, etc. for setting macros to flip build-time conditional switches when parsing spec files. It provides a consistent interface across related tools.They are aliases in
rpmbuild, I'm not sure if there is a better way to accomplish something like that here: