Add --minimal option for check-ugrade command #1519
Conversation
j-mracek
added
blocked
| // Last, only include latest upgrades | ||
| upgrades_query.filter_latest_evr(); | ||
| if (minimal) { | ||
| // when minimal is requested, keep only the earrliest version |
There was a problem hiding this comment.
Small typo: earrliest -> earliest
| @@ -153,8 +176,13 @@ void CheckUpgradeCommand::run() { | |||
| std::move(advisories.value()), installed_query, libdnf5::sack::QueryCmp::GTE); | |||
| } | |||
|
|
|||
| // Last, only include latest upgrades | |||
| upgrades_query.filter_latest_evr(); | |||
| if (minimal) { | |||
There was a problem hiding this comment.
I believe this should be minimal->get_value().
It is also breaking a couple of tests.
There was a problem hiding this comment.
May I ask you to explain your comment in more details?
There was a problem hiding this comment.
There is an update for tests - rpm-software-management/ci-dnf-stack#1511
There was a problem hiding this comment.
I've got it, the test was really incorrect. The test was for pointer and not for bool value in the pointer of BoolOption. Fixed
| "Reports the lowest versions of packages that fix a bugfix, enhancement or a fix for a security issue " | ||
| "(security) on the system."); |
There was a problem hiding this comment.
Both this description and the man page don't mention the newpackage advisory type which is also used.
What about to change it a bit to: Reports the lowest versions of packages that fix advisories of type bugfix, enhancement, security, or newpackage.
Anyway I do like your description much more than the one in upgrade command which is quite ambiguous. Could they be unified? There is even a TODO for it.
j-mracek
force-pushed
the
minimal
branch
2 times, most recently
from
400faf0
to
9efb114
Compare
It is required for a feature parity with upgrade command where the option is already available. Related: https://issues.redhat.com/browse/RHEL-38804
Additional it provides information about relation to other security options
|
Great, thank you. |
78101dc
It is required for a feature parity with upgrade command where the option is already available.
Related: https://issues.redhat.com/browse/RHEL-38804
CI: rpm-software-management/ci-dnf-stack#1511