Move offline from dnf5 to libdnf5 #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/offline-move
branch
from
76abaa4
to
2fb5a9e
Compare
kontura
reviewed
Jun 5, 2024
Comment on lines
93
to
98
| private: | ||
| /// Read offline transaction state data from the file | ||
| void read(); | ||
| std::exception_ptr read_exception; | ||
| std::filesystem::path path; | ||
| OfflineTransactionStateData data; |
There was a problem hiding this comment.
Could we hide this into a p_impl?
Perhaps also the OfflineTransactionStateData could store the data in p_impl and have a bunch of getters/setters for the values?
This would allow us to do modifications later without breaking ABI.
There was a problem hiding this comment.
Sounds reasonable, thanks!
There was a problem hiding this comment.
I've added a commit with pImpls for both classes.
We will need to share the code also with dnf5daemon-server to support offline upgrades using D-Bus API.
This change would allow us to do modification to these classes without breaking ABI.
m-blaha
force-pushed
the
mblaha/offline-move
branch
from
62643ae
to
f20c6f9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need to share the code also with dnf5daemon-server to support
offline upgrades using D-Bus API.
For: https://bugzilla.redhat.com/show_bug.cgi?id=2124503