Commits on Jun 25, 2024

1. Clean up repo header includes

   

   kontura committed Jun 25, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 34a8f52
   • Browse repository at this point

   Copy the full SHA

   34a8f52 View commit details

   Browse the repository at this point in the history

2. Remove unused includes in test_modules

   

   kontura committed Jun 25, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for b6b26d6
   • Browse repository at this point

   Copy the full SHA

   b6b26d6 View commit details

   Browse the repository at this point in the history

3. Add a copr build with disabled modules to verify it works

   

   kontura committed Jun 25, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 3d29235
   • Browse repository at this point

   Copy the full SHA

   3d29235 View commit details

   Browse the repository at this point in the history

4. Implement conditional compilation -DWITH_MODULEMD=OFF …

   When WITH_MODULEMD is turned off module sources are not compiled and
   module headers are not installed.
   
   Public API in non-module headers (base.hpp and goal.hpp) is still
   available but throws an exception when used.
   Another option would be to also hide the functions in non-module headers
   but in order to ensure the headers always match the compiled library (so
   they don't depend on the user not defining `WITH_MODULEMD`) they would
   have to be configured via a constant at compile time. For example using
   cmake to `configure_file` turning them into `.in` files.

   

   kontura committed Jun 25, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for a0970be
   • Browse repository at this point

   Copy the full SHA

   a0970be View commit details

   Browse the repository at this point in the history