Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdnf, actions plugin] Support get/set repositories options, ver 1.1.0 #1539

Conversation

jrohel
Copy link
Contributor

@jrohel jrohel commented Jun 10, 2024

Argument ${conf.<repoid_pattern>.<option_name>[=<value_pattern>]} is substituted by a list of "repoid.option=value" pairs for the matching repositories. Pairs are separated by ',' character. The ',' character in the value is replaced by escape sequence "\x2C".
The input repoid_pattern - is the repository id and can contain globs.
If value_pattern is used, only pairs with the matching value are listed. The value_pattern can contain globs.

Output line format for setting repository option:
conf.<repoid_pattern>.<option_name>=<value> - sets the value of option option_name for all matching repositories.
The repoid_pattern - is repository id and can contain globs.

Closes #1345

@jan-kolarik
Copy link
Member

/packit test --identifier dnf5-tests

@jrohel jrohel force-pushed the feature/libdnf_actions_plugin_repo_opts branch from 3e538dc to a99ad20 Compare June 10, 2024 12:06
Argument `${conf.<repoid_pattern>.<option_name>[=<value_pattern>]}` is
substituted by a list of "repoid.option=value" pairs for the matching
repositories. Pairs are separated by ',' character. The ',' character
in the value is replaced by escape sequence "\x2C".
The input `repoid_pattern` - is the repository id and can contain globs.
If `value_pattern` is used, only pairs with the matching value are
listed. The `value_pattern` can contain globs.

Output line format for setting repository option:
`conf.<repoid_pattern>.<option_name>=<value>` -  sets the value
of option `option_name` for all matching repositories.
The `repoid_pattern` - is repository id and can contain globs.
@jrohel jrohel force-pushed the feature/libdnf_actions_plugin_repo_opts branch from a99ad20 to 98a7358 Compare June 12, 2024 22:42
@jan-kolarik jan-kolarik self-assigned this Jun 13, 2024
Copy link
Member

@jan-kolarik jan-kolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add also CI tests for the newly introduced functionality.

@jrohel
Copy link
Contributor Author

jrohel commented Jun 13, 2024

/packit test --identifier dnf5-tests

@jan-kolarik
Copy link
Member

F39 tests are OK. Build in Rawhide is also OK. The other tests failures is very likely due to creating the PR before merging the #1546 where the issues with builddep plugin was fixed. Merging this ...

@jan-kolarik jan-kolarik added this pull request to the merge queue Jun 17, 2024
Merged via the queue into rpm-software-management:main with commit 7eea8c5 Jun 17, 2024
8 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libdnf actions plugin: possibility to modify per-repository configuration
2 participants