Add "Complete!" message after succesfull transaction #1553
Conversation
dnf5/main.cpp
Outdated
| @@ -1444,6 +1444,11 @@ int main(int argc, char * argv[]) try { | |||
|
|
|||
| log_router.info("DNF5 finished"); | |||
|
|
|||
| // Print Complete! message only when transaction is created to prevent poluting output from repoquery or other command | |||
| if (auto * transaction = context.get_transaction(); transaction && !transaction->empty()) { | |||
| std::cout << "Complete!\n"; | |||
There was a problem hiding this comment.
Do we want to print the message also in quiet (-q) mode? If not, use context.print_info("Complete"); instead of printing directly to std::cout.
In dnf5 quiet mode only partially works. For example, transaction table and transaction progress is visible even in quiet mode. We probably want to fix that as well. But that's out of the scope of this PR.
There was a problem hiding this comment.
Good point, I am changing it to react to -q.
There was a problem hiding this comment.
Anyway scriptlets are still visible in -q mode and even worse, the new line is not added after the last entry.
|
I hope the message does not pollute stdout of "dnf5 repoquery" output. |
It seems, it should not 🙂 |
dnf5/main.cpp
Outdated
| @@ -1444,6 +1444,11 @@ int main(int argc, char * argv[]) try { | |||
|
|
|||
| log_router.info("DNF5 finished"); | |||
|
|
|||
| // Print Complete! message only when transaction is created to prevent poluting output from repoquery or other command | |||
| if (auto * transaction = context.get_transaction(); transaction && !transaction->empty()) { | |||
| std::cout << "Complete!\n"; | |||
There was a problem hiding this comment.
I find the exclamation mark for an information message inappropriate. Could we use "Complete.\n" instead?
There was a problem hiding this comment.
I have no preferences. "Complete!" was used by DNF4.
Keeping the last message something abou scriptlets is not clear message that everything passed correctly and program was terminated correctly. The commit uses the same message like DNF4. Contrary to DNF4, this commit does not add Complete! message when there is anything to perform - no transaction table. Closes: rpm-software-management#613
|
Thanks. |
89ccf36
Keeping the last message something abou scriptlets is not clear message that everything passed correctly and program was terminated correctly. The commit uses the same message like DNF4. Contrary to DNF4, this commit does not add Complete! message when there is anything to perform - no transaction table.
Closes: #613