Debuginfo-install command #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is required for the debuginfo command and it uses the same logik like in DNF4
m-blaha
reviewed
Jul 1, 2024
libdnf5/base/goal.cpp
Outdated
| @@ -74,6 +75,46 @@ void add_obsoletes_to_data(const libdnf5::rpm::PackageQuery & base_query, libdnf | |||
| data |= obsoletes_query; | |||
| } | |||
|
|
|||
| /// Add install jpb of debug packages for installed packages to Goal | |||
| patterns_to_debuginfo_install_options = parser.add_new_values(); | ||
| auto patterns_arg = parser.add_new_positional_arg( | ||
| "patterns", | ||
| ArgumentParser::PositionalArg::UNLIMITED, |
There was a problem hiding this comment.
I'd prefer ArgumentParser::PositionalArg::AT_LEAST_ONE. I think dnf5 debuginfo-install without a spec does not make much sense.
It allows to use it from other interface then only from DNF5
It also describes dropping autoenable debug repositories for other commands.
Merged
via the queue into
rpm-software-management:main
with commit Jul 1, 2024
b58dd8e
1 of 15 checks passed
|
Hey folks, we are getting close to Fedora 41 freeze. Could we get a new release of dnf5 with this code? Thanks |
|
@evan-goode Hi Evan, could you please trigger a new dnf5 release including the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not delivered in this PR:
Tests: Enable several tests for debuginfo-install command
Closes: #846