Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnfdaemon: implement D-Bus API for cleaning caches #1589

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Jul 19, 2024

Changes:

3937511 (Marek Blaha, 46 seconds ago)
dnfdaemon-client: Clean command implemetation

7008046 (Marek Blaha, 20 hours ago)
dnfdaemon: D-Bus API for cleaning caches

Implements clean() method on Base interface to clean requested types of
caches. Supported types are "all", "packages", "metadata", "dbcache", and
also "expire-cache" for marking repository metadata expired.

Resolves: #1179


Remove or expire cached data.
-->
<method name="read_all_repos">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over read_all_repos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

#include <sdbus-c++/sdbus-c++.h>
#include <unistd.h>

#include <iostream>
#include <set>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this header is not actually used.
The std::unordered_set is defined in unordered_set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Implements `clean()` method on `Base` interface to clean requested types
of caches. Supported types are "all", "packages", "metadata", "dbcache",
and also "expire-cache" for marking repository metadata expired.
The transfer id is now generated on the server side, do not pass it in
list_fd() call.
@kontura kontura added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 6525d28 Aug 1, 2024
16 checks passed
@kontura kontura deleted the mblaha/daemon-clean branch August 1, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnf5daemon API to perform dnf5 clean cache_types
2 participants