Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a default user_agent string #1590

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

lleyton
Copy link
Contributor

@lleyton lleyton commented Jul 22, 2024

This implements a default user_agent string as described in https://github.com/rpm-software-management/dnf5/blob/main/doc/dnf5.conf.5.rst.

I also moved the OSRelease class from the COPR plugin into a library util for reuse, as well as a few other functions in conf/vars.

Copy link

We were not able to find or create Copr project packit/rpm-software-management-dnf5-1590 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@kontura kontura self-assigned this Jul 31, 2024
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

I have added just one note + can you fix the formatting issues detected by the Pre Commit Hooks? You can see the specific issues here in the Details.

libdnf5/conf/config_main.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While working on some related functionality I noticed couple more issue.

libdnf5/conf/config_main.cpp Outdated Show resolved Hide resolved
libdnf5/utils/os_release.cpp Outdated Show resolved Hide resolved
@kontura
Copy link
Contributor

kontura commented Aug 26, 2024

@lleyton any update here?

We require these changes also for rpm-software-management/ci-dnf-stack#1501.

@lleyton
Copy link
Contributor Author

lleyton commented Aug 26, 2024

oh sorry! missed your replies, gonna push changes to address the issues in a bit

@lleyton lleyton requested a review from kontura August 26, 2024 04:47
@lleyton
Copy link
Contributor Author

lleyton commented Aug 26, 2024

Should be good now!

@kontura
Copy link
Contributor

kontura commented Aug 26, 2024

Great, thanks.

There is still couple formatting issues.
You can use the pre-commit to do the formatting automatically with pre-commit run --all-files.

@kontura
Copy link
Contributor

kontura commented Aug 26, 2024

The failing CI for 41 and rawhide is not related.

@lleyton
Copy link
Contributor Author

lleyton commented Aug 26, 2024

formatting issues should be fixed

@kontura kontura added this pull request to the merge queue Aug 26, 2024
Merged via the queue into rpm-software-management:main with commit b1f19dd Aug 26, 2024
11 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants