-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a default user_agent string #1590
Conversation
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
I have added just one note + can you fix the formatting issues detected by the Pre Commit Hooks? You can see the specific issues here in the Details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While working on some related functionality I noticed couple more issue.
@lleyton any update here? We require these changes also for rpm-software-management/ci-dnf-stack#1501. |
oh sorry! missed your replies, gonna push changes to address the issues in a bit |
Should be good now! |
Great, thanks. There is still couple formatting issues. |
The failing CI for 41 and rawhide is not related. |
formatting issues should be fixed |
b1f19dd
This implements a default user_agent string as described in https://github.com/rpm-software-management/dnf5/blob/main/doc/dnf5.conf.5.rst.
I also moved the
OSRelease
class from the COPR plugin into a library util for reuse, as well as a few other functions inconf/vars
.