Better error messages for system state loading #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-kolarik
requested changes
Aug 13, 2024
ppisar
reviewed
Aug 13, 2024
ppisar
reviewed
Aug 13, 2024
m-blaha
force-pushed
the
mblaha/state-reason
branch
3 times, most recently
from
bfb591a
to
b04e7c8
Compare
jan-kolarik
approved these changes
Aug 20, 2024
|
/packit copr-build |
|
Please rebase against the latest changes so we can see the build is OK now. Thanks! |
m-blaha
force-pushed
the
mblaha/state-reason
branch
from
b04e7c8
to
3dfd858
Compare
|
Done, let's see the results... |
kontura
reviewed
Aug 20, 2024
doc/misc/system-state.7.rst
Outdated
| Description | ||
| =========== | ||
|
|
||
| The DNF5 system state consists of several TOML files located in the /usr/lib/sysimage/libdnf5/ directory. DNF5 uses the system state to: |
There was a problem hiding this comment.
The /usr/lib/sysimage/libdnf5/ is the default but I think we should mention that the location is taken from system_state_dir config option.
|
Interestingly, there are some TOML unit tests failing, though after merging the #1625 it was green: EDIT: Oh I see it's actually related to the PR :) |
There are multiple exceptions that can occur during loading the system state from toml files. Now they are caught and wrapped in StateLoadError.
The page also contains information how to recover from corrupted system state files.
m-blaha
force-pushed
the
mblaha/state-reason
branch
from
3dfd858
to
e147626
Compare
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a man page on DNF system state. This man page is then referenced in system state loading error messages.
Resolves: #1550
Changes:
ac68a07 (Marek Blaha, 5 days ago)
doc: Add man page describing the system state
The page also contains information how to recover from corrupted system
state files.
888d955 (Marek Blaha, 5 days ago)
state: Catch all errors during system state load
There are multiple exceptions that can occur during loading the system
state from toml files. Now they are caught and wrapped in StateLoadError.