Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the output of failed scriptlets to the user #1652

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Show the output of failed scriptlets to the user #1652

merged 3 commits into from
Aug 28, 2024
+79 −4

Commits on Aug 28, 2024

  1. rpm::transaction: Base::Transaction to callback holder 

    Handling scriptlet outputs requires rpm transaction callbacks to have
access to the `libdnf5::Base::Transaction` instance the rpm transaction
belongs to.
    @m-blaha
    m-blaha committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    de604d3 View commit details
    Browse the repository at this point in the history

  2. transaction: Store outputs of the last rpm scriptlet 

    The outputs of the most recently executed RPM scriptlet in the
transaction are stored and can be accessed by the user through the
Base::Transaction::get_last_script_output() method.
    @m-blaha
    m-blaha committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b11e7aa View commit details
    Browse the repository at this point in the history

  3. dnf5: Print rpm scriptlets outputs to the user 

    If a scriptlet fails, its output is displayed to the user in addition to
being written to the log. For scriptlets that complete successfully, the
output is only logged.
    @m-blaha
    m-blaha committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e2794e2 View commit details
    Browse the repository at this point in the history