config-manager: Fix addrepo from-repofile with empty/comment lines #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jan-kolarik
reviewed
Sep 4, 2024
Comments and empty lines were interpreted as options in the configuration file validity test. Now they are ignored.
jrohel
force-pushed
the
fix/config_manager_plugin_comment_empty_line
branch
from
200d2f3
to
9cd1bc8
Compare
jan-kolarik
approved these changes
Sep 5, 2024
|
The 3 failing tests are not related to this PR, it seems they were introduced after merging #1641 and related tests. I will look into that... |
Merged
via the queue into
rpm-software-management:main
with commit Sep 5, 2024
546af1d
9 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments and blank lines were interpreted as options in the configuration file validity test. Now they are ignored.
Closes: #1603