dnfdaemon: Fix issues with introspection files #1676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the server is sending session_object_path argument as a string, although it is declared as "object path" type. Changing to strings to resolve runtime warnings on the client side. See #1646 for details.
|
Closed in favor of #1679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1646
Resolves: #1665 (comment)
Changes:
dd04451 (Marek Blaha, 4 minutes ago)
daemon: Adjust signal argument types
It looks like the server is sending session_object_path argument as a
string, although it is declared as "object path" type. Changing to strings
to resolve runtime warnings on the client side. See
#1646 for details.
5fe2eae (Marek Blaha, 2 hours ago)
daemon: Fix missing direction for Goal.cancel()