-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: Reset the goal #1678
daemon: Reset the goal #1678
Conversation
I'm not totally sure about automatically resetting after the transaction is done. The transaction might still be needed for follow-up calls, like collecting RPM errors that happened during execution. |
Aha, you are right. If the errors reported by In fact, I planned to call the |
3cd0a6e
to
489eb0f
Compare
I gave a quick test to the changes in the current form and it works as expected in my use case. I tried to install/uninstall packages with not shared and with shared session and both cases work fine, including when "simulating" a transaction to figure out needed size to download/install. |
The reset() method currently does not reset all Goal members. This patch adds those that are missing.
The method resets the current goal and transaction, which is necessary for scenarios where the user wants to reuse the D-Bus session to resolve or execute multiple transactions.
With this patch the user can re-use the session to resolve multiple transactions without running them. The use case might be to check what dependencies would be installed with given package.
489eb0f
to
6dd2cb7
Compare
New D-Bus API to reset the goal.
Resolves: #1653
Changes:
3cd0a6e (Marek Blaha, 5 minutes ago)
dnfdaemon: D-Bus API to reset the goal
With this patch the user can re-use the session to resolve multiple
transactions without running them. The use case might be to check what
dependencies would be installed with given package.
d77231b (Marek Blaha, 17 hours ago)
dnfdaemon: Add reset_goal() method
The method resets the current goal and transaction, which is necessary for
scenarios where the user wants to reuse the D-Bus session to resolve or
execute multiple transactions.
5dbe16a (Marek Blaha, 17 hours ago)
goal: Add missing members to reset() method
The reset() method currently does not reset all Goal members. This patch
adds those that are missing.