I18N: Mark messages in "dnf info" output for a translation #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
force-pushed
the
i18n_dnf_info
branch
from
97c1bf5
to
2610a58
Compare
pkratoch
reviewed
Sep 17, 2024
| @@ -52,25 +52,25 @@ void print_package_info( | |||
| scols_table_enable_noheadings(table, 1); | |||
| scols_table_new_column(table, "key", 1, 0); | |||
| scols_table_new_column(table, "value", 1, SCOLS_FL_WRAP); | |||
| scols_table_set_column_separator(table, " : "); | |||
| scols_table_set_column_separator(table, _(" : ")); | |||
There was a problem hiding this comment.
Is it expected that the translators know what purpose this string serve or should a note, such as https://github.com/rpm-software-management/dnf5/blob/main/dnf5daemon-client/commands/advisory/arguments.hpp#L153-L154 , be added?
There was a problem hiding this comment.
We can add a comment. I'm not sure how to describe it. Because the colon here is abused as a column separator. The current use in the English text is wrong from typographical point of view.
There was a problem hiding this comment.
I added this notice:
// Note for translators: This is a right-aligned column separator in
// a package properties table as in "Name : bash".
ppisar
force-pushed
the
i18n_dnf_info
branch
from
2610a58
to
67b1fb2
Compare
Merged
via the queue into
rpm-software-management:main
with commit Sep 17, 2024
95593e1
13 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1687