Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdbus::ObjectPath when checking signals object_path #1711

Merged

Commits on Sep 19, 2024

  1. Fix deserialization when checking signals object_path

    Since rpm-software-management#1679
    `sdbus::ObjectPath` is send over to the client not std::string.
    
    This was causing the check `signature_valid(sdbus::Signal &)` to crash,
    the client callback ended and the server kept waiting for result
    of the `key_import` userconfirm.
    kontura committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    30c7697 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. dnf5daemon-server: Run transaction test for offline transactions

    A serialized offline transaction consists only of local packages
    downloaded to the `<system state dir>/offline` location. Unfortunately,
    PGP checks for these packages are disabled by default due to the
    `localpkg_gpgcheck` option default value.
    Instead of testing the serialized transaction, this patch performs an
    RPM transaction test on the originally resolved transaction, which still
    retains information about the repositories from which the packages were
    downloaded.
    This approach also saves time required for deserialization and resolving
    the testing transaction.
    
    This ports the fix from rpm-software-management#1672
    to dnf5daemon.
    kontura committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8a447f4 View commit details
    Browse the repository at this point in the history