Do not install /var/cache/libdnf5 directory #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootc systems tend to prune /var directory <https://containers.github.io/bootc/filesystem.html#var>. That breaks verifying integrity with "rpm --verify libdnf5". This patch stops installing /var/cache/libdnf5 directory, but keeps tracking it by libdn5 RPM package. The directory is created by libdnf5 whenever it is needed. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2313032
|
Is this change suitable for upstream (make install), or should we restrict it to dnf5.spec ("rm %{buildroot}/%{_var}/cache/libdfn5" in %install section)? |
m-blaha
approved these changes
Sep 19, 2024
Merged
via the queue into
rpm-software-management:main
with commit Sep 20, 2024
5cc72c6
16 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootc systems tend to prune /var directory
https://containers.github.io/bootc/filesystem.html#var. That breaks verifying integrity with "rpm --verify libdnf5".
This patch stops installing /var/cache/libdnf5 directory, but keeps tracking it by libdn5 RPM package. The directory is created by libdnf5 whenever it is needed.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2313032