Optimize getting counts of transaction items #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related BZ ticket: https://bugzilla.redhat.com/show_bug.cgi?id=2315665. |
jan-kolarik
reviewed
Oct 22, 2024
jan-kolarik
reviewed
Oct 22, 2024
Previously during `history list` we separately fetched all transaction packages, groups and environments only to count them. This could be quite slow because it resulted in a lot of separate DB connections. Now we fetch only the counts and use only one DB connection.
kontura
force-pushed
the
history_item_count_sep
branch
from
158fffc
to
d57a87c
Compare
Merged
via the queue into
rpm-software-management:main
with commit Oct 24, 2024
f1e8d1b
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously during
history listwe separately fetched all transaction packages, groups and environments only to count them. This could be quite slow because it resulted in a lot of separate DB connections.Now we fetch only the counts and use only one DB connection. To maintain compatibility the counts are passed as an optional parameter and if missing we fallback to the old (slow) computation.