Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reldep_parser: Revert reldep regex to match dnf #827

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

jan-kolarik
Copy link
Member

@jan-kolarik jan-kolarik commented Aug 16, 2023

Fix reldep regex to match the parsing from dnf to work also with expressions without spaces between cmp and evr.

CI test: rpm-software-management/ci-dnf-stack#1365.
Closes #825.

@ppisar
Copy link
Contributor

ppisar commented Aug 16, 2023

That looks reasonable. Provided those listed are the the only recognized reldep operators.

@jan-kolarik
Copy link
Member Author

jan-kolarik commented Aug 17, 2023

That looks reasonable. Provided those listed are the the only recognized reldep operators.

Yes, currently dnf5 supports EQ, GT, GTE, LT, LTE operators and also using only name without cmp and evr. All of these is matched with these PR changes.

Fix reldep regex to match the parsing from dnf to work also with expressions without spaces between cmp and evr.
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@kontura kontura added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 78cdf51 Aug 22, 2023
6 checks passed
@kontura kontura deleted the jkolarik/reldep-regex-fix branch August 22, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

dnf5 remove "kernel-core >6.4.5" != dnf remove "kernel-core >6.4.5"
4 participants