Add ccache Github workflow #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inknos
force-pushed
the
ns-ccache-ghactions
branch
27 times, most recently
from
16301ff
to
b8b5b21
Compare
inknos
force-pushed
the
ns-ccache-ghactions
branch
from
9293386
to
927e8bf
Compare
inknos
commented
Sep 14, 2023
.github/workflows/ccache-build.yaml
Outdated
Comment on lines
23
to
26
| # this step needs to be incorporated in our container that we use for testing | ||
| - name: Install dependencies | ||
| run: | | ||
| dnf install -y ccache clang && dnf builddep -y ./dnf5.spec |
There was a problem hiding this comment.
@m-blaha about this, would you rather update our current container that we use for CI or should we create a separate image for building?
There was a problem hiding this comment.
I'd prefer to keep one container.
There was a problem hiding this comment.
also, the COPR secret needs to be fixed. I'll do those two fixes before merging
inknos
force-pushed
the
ns-ccache-ghactions
branch
6 times, most recently
from
1f715ac
to
d63a76c
Compare
inknos
force-pushed
the
ns-ccache-ghactions
branch
2 times, most recently
from
dfbab73
to
de96510
Compare
|
looks like the names the workflows are not updated. I'll retry to run them tomorrow |
inknos
force-pushed
the
ns-ccache-ghactions
branch
4 times, most recently
from
02e3506
to
ebb04ef
Compare
This workflow aims to replace the current ci action[1] exploiting ccache to run cmake builds quicker. It shares cache for the same PRs and for the branch each PR is opened against. [1]: https://github.com/rpm-software-management/dnf5/blob/main/.github/workflows/ci.yml#L9-L45
inknos
force-pushed
the
ns-ccache-ghactions
branch
from
c375d41
to
50e5519
Compare
Merged
via the queue into
rpm-software-management:main
with commit Sep 20, 2023
b00d940
5 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.