Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap inner mount orphan kill #1166

Closed
wants to merge 2 commits into from
Closed

Bootstrap inner mount orphan kill #1166

wants to merge 2 commits into from

Conversation

praiskup
Copy link
Member

No description provided.

@praiskup
Move the umount() call to the parent Mount class
58f082f 
This allows us to do some generic logic on one place, like setting the
internal object state.
@praiskup
Automatically kill processes in bootstrap inner mount
ae49558 
Fixes: rpm-software-management#1165
@praiskup praiskup added the release-blocker This needs to be shipped in the next release label Jul 27, 2023
@praiskup praiskup mentioned this pull request Jul 24, 2023
Closed
6 tasks
FrostyX
FrostyX approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@FrostyX FrostyX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to reproduce the issue and test the patch properly. But it looks reasonable to me, and it fixes tests, so I would go for it.

@praiskup
Copy link
Member Author

praiskup commented Aug 4, 2023

Reproducing this is relatively easy:

$ mock --postinstall --isolation=simple https://github.com/rpm-software-management/mock-test-data/raw/main/daemontest-1-0.src.rpm
... successful build, mock exists ...
$ pgrep daemontest -a
41652 daemontest PID=41652

@praiskup praiskup closed this in bd38f5c Aug 4, 2023
@praiskup praiskup deleted the inner-mount-orphan-kill branch August 4, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrostyX FrostyX FrostyX approved these changes

Assignees
No one assigned
Labels
release-blocker This needs to be shipped in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praiskup @FrostyX