-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap_image and the local repositories #1167
Conversation
praiskup
commented
Jul 27, 2023
•
edited
Loading
edited
We can not use user_mountpoints because these aren't (historically, not sure what are the reasons) mounted too late during the Buildroot preparation (after the self._init_pkg_management()). This isn't actually an issue when 'use_bootstrap_image == False' because we use the package manager on host (so it actually sees the repository on host). So newly we place the local_repo mount points into the "managed" category, which seems even semantically better now. We though need to call the 'self.mounts.mountall_managed()' method a little bit later than before, when the local repo BindMountPoints are already defined by self.pkg_manager.initialize(). Closes: rpm-software-management#1167
We can not use user_mountpoints because these aren't (historically, not sure what are the reasons) mounted too late during the Buildroot preparation (after the self._init_pkg_management()). This isn't actually an issue when 'use_bootstrap_image == False' because we use the package manager on host (so it actually sees the repository on host). So newly we place the local_repo mount points into the "managed" category, which seems even semantically better now. We though need to call the 'self.mounts.mountall_managed()' method a little bit later than before, when the local repo BindMountPoints are already defined by self.pkg_manager.initialize(). Closes: rpm-software-management#1167
We can not use user_mountpoints because these aren't (historically, not sure what are the reasons) mounted too late during the Buildroot preparation (after the self._init_pkg_management()). This isn't actually an issue when 'use_bootstrap_image == False' because we use the package manager on host (so it actually sees the repository on host). So newly we place the local_repo mount points into the "managed" category, which seems even semantically better now. We though need to call the 'self.mounts.mountall_managed()' method a little bit later than before, when the local repo BindMountPoints are already defined by self.pkg_manager.initialize(). Closes: rpm-software-management#1167
I tried the combination of local repositories and bootstrap image and it seems to work even without this PR
And the repo is successfully synced
and the package is successfully installed from the repository
So I am probably misunderstanding the issue? |
Wow, I was never able to run Mock like that, I always do
I bet this is related to mock/mock/integration-tests/24-postinstall.tst Lines 18 to 19 in 6c7efb6
|
You might need to |
Ouch, no, this was detected by a different test case, sorry: mock/mock/integration-tests/20-lvm-plugin.tst Lines 63 to 64 in 6c7efb6
|
We can not use user_mountpoints because these aren't (historically, not sure what are the reasons) mounted too late during the Buildroot preparation (after the self._init_pkg_management()). This isn't actually an issue when 'use_bootstrap_image == False' because we use the package manager on host (so it actually sees the repository on host). So newly we place the local_repo mount points into the "managed" category, which seems even semantically better now. We though need to call the 'self.mounts.mountall_managed()' method a little bit later than before, when the local repo BindMountPoints are already defined by self.pkg_manager.initialize(). This problem has been triggered by the LVM test-case that creates a custom local_repo (on host) with `baseurl=/tmp/foo` that needs to be bind-mounted into the bootstrap chroot properly. Closes: rpm-software-management#1167
I updated the commit message with the info on how this can be triggered. |