check if bootstrap buildroot has tpmdir #1362
Conversation
| @@ -880,7 +880,7 @@ def _setup_nosync(self): | |||
| multilib = ('x86_64', 's390x') | |||
| # ld_preload need to be same as in bootstrap because we call DNF in bootstrap, but | |||
| # but it will load nosync from the final chroot | |||
| if self.bootstrap_buildroot is not None: | |||
| if self.bootstrap_buildroot is not None and self.bootstrap_buildroot.tmpdir is not None: | |||
There was a problem hiding this comment.
Depending on the need for 75e3f8a, we may either update the _init_locked() fallback, or we can stop sharing the directories.
There was a problem hiding this comment.
No. I do not remember. The only clue for today's-us is the comment above the code and the referenced issue.
There was a problem hiding this comment.
I think that what is happening is:
- one mock process initializes the bootstrap chroot and buildroot, and has them "locked"
- another mock process tries to initialize bootstrap, but fails to lock ... so it doesn't initialize the
tmptdirvalue for bootstrap, so the buildroot'sbootstrap_buildroot.tmpdirvalue is None later
The commit 7b40a26 relates to this because with that we started sharing tmpdir directory for bootstrap and target chroot's (both Buildroot's have the same .tmpdir value), the question is whether we need that.
The .tmpdir is only used by nosync logic, and nosync is broken. So it is quite complicated to fix at this point in time.
|
The problem with tmpdir is still painful, but since the nosync.rpm package is broken - it is pretty hard to debug and confirm we fixed something. Let's delay the fix till nosync.rpm is fixed. |
Fixes #1351