Enable RPM sysusers integration #1367

nikromen · 2024-04-28T15:16:42Z

Provide users/groups via /usr/lib/sysusers.d. This is going
to be handled by RPM as described in
https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation
and https://lists.fedoraproject.org/archives/list/[email protected]/thread/NEFOV236FJYS2RED2SEOV5YHDFLDX7DK/#KB6KS3U7RO4AYANGSUNVSG7UF5AW52Q2

Fixes fedora-copr/copr#2789

xsuchy · 2024-04-28T19:29:25Z

what about %files section?

mock-core-configs/mock-core-configs.spec

xsuchy · 2024-07-23T07:21:53Z

I think this still miss a few things: BuildRequires and %pre macro. See https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation

xsuchy · 2024-07-23T07:23:02Z

Additionally, it would be nice if you amend https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation and for package that provides the user do s/mock/mock-core-configs/.

praiskup · 2024-07-23T07:34:18Z

Additionally, it would be nice if you amend https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation and for package that provides the user do s/mock/mock-core-configs/.

.. or mock-filesystem.

xsuchy · 2024-07-23T14:54:29Z

Why you removed that line from %files section?

nikromen · 2024-07-23T15:35:37Z

The %sysusers_create_compat macro will generate something like this:

# generated from mock.conf.
getent group 'mock' >/dev/null || groupadd -r 'mock' || :
getent passwd 'mock' >/dev/null || \
    useradd -r -g 'mock' -d '/run/mock' -s '/sbin/nologin' -c 'Runs Uid '\''N'\'' some text' 'mock' || :

so the line in files is no longer needed

xsuchy · 2024-07-23T16:36:44Z

I meant:

%files
%{_sysusersdir}/mock.conf

But you added it back with latest update. It is ok then.

mock/mock.spec

praiskup · 2024-07-24T08:42:10Z

I tried to install on UBI8:

  Installing       : mock-5.6.post1-1.git.3754.50829bf.el8.noarch                                                                                                                                                                     52/53 
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root

  Installing       : mock-core-configs-40.6-1.git.3754.50829bf.el8.noarch                                                                                                                                                             53/53 
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
warning: group mock does not exist - using root
...

mock/mock.spec

xsuchy · 2024-07-25T08:54:31Z

mock/mock.spec

@@ -17,7 +16,8 @@ License: GPL-2.0-or-later
 # cd mock
 # git reset --hard %%{name}-%%{version}
 # tito build --tgz
-Source: %{name}-%{version}.tar.gz
+Source0: %{name}-%{version}.tar.gz
+Source1: https://raw.githubusercontent.com/rpm-software-management/mock/main/mock-core-configs/mock.conf


This is the way to address the file in %pre when macros are evaluated (before the tarball is extrected).

I think you are confusing %pre and %prep.

No no ... the %sysusers_create_compat macro is evaluated at the time when the tarball isn't extracted, yet. See how it is defined, it contains the shell-script macro %().

So this is bad?
https://src.fedoraproject.org/rpms/bodhi-server/blob/rawhide/f/bodhi-server.spec#_125

According to my experiments, ... yes? But maybe I'm doing something wrong.

Yeah, I tried to install bodhi-server in fedora:rawhide container, and there's no bodhi user/group:

[root@db5467446600 /]# grep bodhi /etc/group /etc/passwd [root@db5467446600 /]#

The reason nobody noticed is that they (probably) install it on servers with systemd.

they also try to work around this by defining the file directly in spec
https://src.fedoraproject.org/rpms/bodhi-server/blob/rawhide/f/bodhi-server.spec#_84

it seems like hard task to push the .sysusers file from upstream to %pre...

That is wrong approach, the -f file needs to contain shell script, not the sysusersdir content.

Actually, as I realized in the other thread, the feature is now RPM built-in. But it still doesn't work for the bodhi-server :-) confusing as hell. I think the problem actually is that the dropin has .sysusers suffix instead of .conf. I'm trying to propose a fix here.

mock/mock.spec

releng/release-notes-next/sysusers-handled-by-rpm.feature

mock/mock.spec

praiskup · 2024-07-29T15:03:18Z

The release notes snippet deserves update, otherwise LGTM

mock/mock.spec

praiskup · 2024-07-30T14:07:24Z

Hmpf, now I recall I've seen this feature before, and guess what :)

[root@a7cd3c91a144 /]# rpm -q --provides mock-5.6.post1-1.git.3755.7d754b2.fc41.noarch | grep group
group(mock) = ZyBtb2NrIDEzNSAt

mock/mock.spec

praiskup · 2024-07-30T15:47:08Z

mock/mock.spec

@@ -169,6 +169,9 @@ done

 ./precompile-bash-completion "mock.complete"

+# this is what %%sysusers_create_compat will expand to
+%{_rpmconfigdir}/sysusers.generate-pre.sh mock.conf > sysusers_script


I eventually think that we do not need this %pre dance at all for systems with RPM >= 4.19. I'd use something like:

%if 0%{!?fedora:1} && ( 0%{?rhel} <= 9 || ... others older distros may come ... ) %{_rpmconfigdir}/sysusers.generate-pre.sh mock.conf > sysusers_script

Without this EL10+ condition, we risk a conflict of the "built-in" mechanism and the %pre code.

praiskup · 2024-07-30T15:51:07Z

Interesting reading:

releng/release-notes-next/sysusers-handled-by-rpm.feature

Provide users/groups via `/usr/lib/sysusers.d`. This is going to be handled by RPM as described in https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation and https://lists.fedoraproject.org/archives/list/[email protected]/thread/NEFOV236FJYS2RED2SEOV5YHDFLDX7DK/#KB6KS3U7RO4AYANGSUNVSG7UF5AW52Q2 Relates to fedora-copr/copr#2789

xsuchy

+1

The script for generating the %pre scriptlet is non-existing on new distributions (like Mageia now, but Fedora will drop that sooner or later, too). The build of Mock on Mageia previously relied on sysusers.generate-pre.sh, and failed. The sysusers feature is an RPM built-in anyway (on modern systems), so there's no reason to duplicate the logic in %pre. Generate the %pre scriptlet only for older distributions. Complements: rpm-software-management#1367 Relates: rpm-software-management#289 Relates: fedora-copr/copr#2789

Complements: rpm-software-management#1367 Relates: rpm-software-management#289 Closes: rpm-software-management#1498 Relates: fedora-copr/copr#2789

Complements: rpm-software-management#1367 Relates: rpm-software-management#289 Closes: rpm-software-management#1498 Relates: fedora-copr/copr#2789 Co-authored-by: Neal Gompa (ニール・ゴンパ) <[email protected]>

nikromen marked this pull request as draft April 28, 2024 15:16

nikromen force-pushed the provice-groups-via-sysusers branch from b347681 to 2b1b941 Compare July 22, 2024 14:55

praiskup reviewed Jul 23, 2024

View reviewed changes

mock-core-configs/mock-core-configs.spec Outdated Show resolved Hide resolved

nikromen force-pushed the provice-groups-via-sysusers branch 3 times, most recently from 7968df6 to d348272 Compare July 23, 2024 11:51

nikromen changed the title ~~Revert "revert sysusers setting [RHBZ#1740545]"~~ Enable RPM sysusers integration Jul 23, 2024

nikromen force-pushed the provice-groups-via-sysusers branch from d348272 to 4c8cd88 Compare July 23, 2024 14:45

nikromen force-pushed the provice-groups-via-sysusers branch from 4c8cd88 to 353c12a Compare July 23, 2024 14:57

praiskup reviewed Jul 24, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

praiskup reviewed Jul 24, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

nikromen force-pushed the provice-groups-via-sysusers branch from 353c12a to ab1e9a5 Compare July 24, 2024 14:27

praiskup reviewed Jul 25, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

praiskup reviewed Jul 25, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

xsuchy reviewed Jul 25, 2024

View reviewed changes

nikromen force-pushed the provice-groups-via-sysusers branch 4 times, most recently from 55d852e to 1fd4da3 Compare July 25, 2024 15:41

psf-chronographer bot added the bot:chronographer:provided label Jul 25, 2024

nikromen force-pushed the provice-groups-via-sysusers branch 2 times, most recently from 392a041 to 442074b Compare July 29, 2024 11:42

nikromen force-pushed the provice-groups-via-sysusers branch 2 times, most recently from 29afaaa to 52dab30 Compare July 29, 2024 11:43

praiskup reviewed Jul 29, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

nikromen force-pushed the provice-groups-via-sysusers branch from 52dab30 to 03f8f00 Compare July 29, 2024 12:14

nikromen marked this pull request as ready for review July 29, 2024 13:39

praiskup reviewed Jul 29, 2024

View reviewed changes

releng/release-notes-next/sysusers-handled-by-rpm.feature Outdated Show resolved Hide resolved

praiskup reviewed Jul 29, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

praiskup reviewed Jul 29, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

nikromen force-pushed the provice-groups-via-sysusers branch from 03f8f00 to 0cfadda Compare July 29, 2024 16:22

praiskup reviewed Jul 30, 2024

View reviewed changes

mock/mock.spec Outdated Show resolved Hide resolved

praiskup reviewed Jul 30, 2024

View reviewed changes

praiskup reviewed Jul 31, 2024

View reviewed changes

releng/release-notes-next/sysusers-handled-by-rpm.feature Outdated Show resolved Hide resolved

nikromen force-pushed the provice-groups-via-sysusers branch 2 times, most recently from 3285a6b to 927d25f Compare August 5, 2024 10:58

nikromen force-pushed the provice-groups-via-sysusers branch from 927d25f to 08966e2 Compare August 5, 2024 11:17

xsuchy approved these changes Aug 5, 2024

View reviewed changes

xsuchy merged commit 5071073 into rpm-software-management:main Aug 5, 2024
21 of 22 checks passed

praiskup mentioned this pull request Nov 1, 2024

mock: avoid the %pre scriptlet if possible #1498

Open

praiskup added a commit to praiskup/mock that referenced this pull request Nov 1, 2024

mock: avoid the %pre scriptlet if possible

73c571d

Complements: rpm-software-management#1367 Relates: rpm-software-management#289 Closes: rpm-software-management#1498 Relates: fedora-copr/copr#2789

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable RPM sysusers integration #1367

Enable RPM sysusers integration #1367

nikromen commented Apr 28, 2024 •

edited

Loading

xsuchy commented Apr 28, 2024

xsuchy commented Jul 23, 2024

xsuchy commented Jul 23, 2024

praiskup commented Jul 23, 2024

xsuchy commented Jul 23, 2024

nikromen commented Jul 23, 2024 •

edited

Loading

xsuchy commented Jul 23, 2024 •

edited

Loading

praiskup commented Jul 24, 2024

xsuchy Jul 25, 2024

praiskup Jul 26, 2024

xsuchy Jul 26, 2024

praiskup Jul 26, 2024

xsuchy Jul 26, 2024

praiskup Jul 26, 2024

praiskup Jul 26, 2024

nikromen Jul 26, 2024

praiskup Jul 26, 2024

praiskup Jul 31, 2024

praiskup commented Jul 29, 2024

praiskup commented Jul 30, 2024

praiskup Jul 30, 2024 •

edited

Loading

praiskup Jul 31, 2024

praiskup commented Jul 30, 2024

xsuchy left a comment

Enable RPM sysusers integration #1367

Enable RPM sysusers integration #1367

Conversation

nikromen commented Apr 28, 2024 • edited Loading

xsuchy commented Apr 28, 2024

xsuchy commented Jul 23, 2024

xsuchy commented Jul 23, 2024

praiskup commented Jul 23, 2024

xsuchy commented Jul 23, 2024

nikromen commented Jul 23, 2024 • edited Loading

xsuchy commented Jul 23, 2024 • edited Loading

praiskup commented Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praiskup commented Jul 29, 2024

praiskup commented Jul 30, 2024

praiskup Jul 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praiskup commented Jul 30, 2024

xsuchy left a comment

Choose a reason for hiding this comment

nikromen commented Apr 28, 2024 •

edited

Loading

nikromen commented Jul 23, 2024 •

edited

Loading

xsuchy commented Jul 23, 2024 •

edited

Loading

praiskup Jul 30, 2024 •

edited

Loading