Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composed c10s repos #1383

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Add composed c10s repos #1383

merged 2 commits into from
Jun 15, 2024

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jun 11, 2024 •
edited
Loading

@hroncok
Copy link
Contributor Author

hroncok commented Jun 11, 2024

I have tested this together with rpm-software-management/distribution-gpg-keys#119 and it works.

@hroncok hroncok mentioned this pull request Jun 11, 2024
Merged
@praiskup
Copy link
Member

Can you please bump the distribution-gpg-keys requirement to 1.104 and provide the towncrier snippet?

@praiskup
Copy link
Member

Per this CI log:

Please provide release notes snippet, per the instructions
https://rpm-software-management.github.io/mock/Release-Notes-New-Entry

@hroncok
Copy link
Contributor Author

hroncok commented Jun 12, 2024

I can do that later. Or you can amend my PR (I'm OK with that), if you want to merge sooner.

@ekohl ekohl mentioned this pull request Jun 12, 2024
Merged
@davide125
Copy link

This needs to be reworked to point to the mirrors instead of composes now that we have c10s published on the mirrors. It also needs an additional stanza for Extras (which provides SIG release packages), similar to the one we have in the c9s template.

@hroncok
Copy link
Contributor Author

hroncok commented Jun 14, 2024

This needs to be reworked to point to the mirrors instead of composes now that we have c10s published on the mirrors.

Not even the c10s centos-stream-release package has that yet.

https://gitlab.com/redhat/centos-stream/rpms/centos-release/-/blob/c10s/centos.repo?ref_type=heads

It also needs an additional stanza for Extras (which provides SIG release packages), similar to the one we have in the c9s template.

Where do I find the repo URLs?

I disagree this needs to be done. We can have gradual improvements. This has been tested and works.

Once the centos-stream-release package is updated with mirrored repos, we can do the same.

@praiskup changelog added, gpg-keys requirement bumped

@davide125
Copy link

It also needs an additional stanza for Extras (which provides SIG release packages), similar to the one we have in the c9s template.

Where do I find the repo URLs?

https://mirror.stream.centos.org/SIGs/10-stream/extras/x86_64/extras-common/

I disagree this needs to be done. We can have gradual improvements. This has been tested and works.

Once the centos-stream-release package is updated with mirrored repos, we can do the same.

Totally agree, incremental improvements are the way to go. Re-reading my comment it came out stronger than I meant, sorry about that.

@praiskup
Copy link
Member

Sorry for the changelog-change CI failure; the file clearly is there, but the changed-files addon doesn't detect it.

@praiskup
configs: c10s config update
76d18ff 
- use metalinks instead of compose URLs, the same is happening in
  centos-release: https://gitlab.com/redhat/centos-stream/rpms/centos-release/-/merge_requests/54
- sync a bit with c9s (order of repositories, repo config options)
- set metadata_expire=1
- drop repo_gpgcheck=0 which is the DNF default (and we don't use it in
  most of the other configs)
@praiskup
Copy link
Member

I'm for merging the current state. @hroncok @Conan-Kudo @davide125 wdyt?

@praiskup
Copy link
Member 

PASSED: centos-stream-10-x86_64.cfg (tmpfs)
PASSED: centos-stream-10-x86_64.cfg
PASSED: centos-stream-8-x86_64.cfg (tmpfs)
PASSED: centos-stream-8-x86_64.cfg
PASSED: centos-stream-9-x86_64.cfg (tmpfs)
PASSED: centos-stream-9-x86_64.cfg

@praiskup praiskup merged commit 9e59629 into rpm-software-management:main Jun 15, 2024
20 of 21 checks passed
@praiskup praiskup mentioned this pull request Jun 15, 2024
Closed
@hroncok hroncok deleted the c10s-compose branch June 15, 2024 10:40
@hroncok
Copy link
Contributor Author

hroncok commented Jun 17, 2024

Not all repos were converted to metalinks. See #1390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praiskup praiskup praiskup left review comments

@davide125 davide125 davide125 left review comments

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add c10s compose to the centos-stream-10 config
4 participants
@hroncok @praiskup @davide125 @Conan-Kudo