Fix the permissions for (re)created resultdir #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already handled by the preceding resetLogging() call. Relates: rpm-software-management#1467
praiskup
force-pushed
the
praiskup-resultdir-permissions
branch
from
48217f1
to
d690bca
Compare
To make the fix possible, we needed to make the result directory creation method public. Fixes: rpm-software-management#1467
praiskup
force-pushed
the
praiskup-resultdir-permissions
branch
from
d690bca
to
a0155c5
Compare
|
I plan to merge this early and wrap the release (once the CI gets green). Please comment ASAP. |
xsuchy
reviewed
Sep 26, 2024
| @@ -477,7 +477,6 @@ def chain(self, args, options, buildroot): | |||
| resultdir = os.path.join(self.config['local_repo_dir'], pdn) | |||
| self.buildroot.resultdir = resultdir | |||
| self.buildroot.resetLogging(force=True) | |||
| file_util.mkdirIfAbsent(resultdir) | |||
There was a problem hiding this comment.
Uff. I'm not sure about this. But yeah, in theory it should not be needed. Let be brave and do it.
There was a problem hiding this comment.
mock/mock/py/mockbuild/buildroot.py
Lines 627 to 632 in 8122bda
This is the force=True case, I think we are safe.
Merged
praiskup
commented
Sep 27, 2024
| @@ -56,7 +56,7 @@ def __scanChroot(self): | |||
| regexstr = "|".join(self.scan_opts['regexes']) | |||
| regex = re.compile(regexstr) | |||
| chroot = self.buildroot.make_chroot_path() | |||
| file_util.mkdirIfAbsent(self.resultdir) | |||
| self.buildroot.create_resultdir() | |||
There was a problem hiding this comment.
Argh! While it was causing issues before, now it is broken even more -> because self.resultdir is not serl.buildroot.resultdir, nah. chroot_scan is broken in 5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1467