Fix the dnf -> dnf4 alias #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
praiskup-dnf4-aliase-no-2
branch
2 times, most recently
from
9abe5f7
to
99164b6
Compare
praiskup
force-pushed
the
praiskup-dnf4-aliase-no-2
branch
from
99164b6
to
34cc381
Compare
When package_manager = dnf, 'dnf4' is to be selected and used when bootstrap chroot is disabled. This was not detected by test-suite; my bet is that we do tests with testConfig=fedora-40-x86_64 which is already dnf5 and we have dnf5 installed on the testing machines. I'm trying to modify one test-case to test DNF4 chroot explicitly. Fixes: rpm-software-management#1475
The rename of methods makes linter thing these are new issues: - Ignore the f"" warning, as f-string is not optimal for this use-case. - Use RuntimeError instead of the generic Exception. It is still too generic and mock prints stack trace if it happens, but package_manager.py probably deserves it's own exception (rpm-software-management#1477).
praiskup
force-pushed
the
praiskup-dnf4-aliase-no-2
branch
from
34cc381
to
1fed15e
Compare
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Sep 30, 2024
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Sep 30, 2024
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Sep 30, 2024
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Sep 30, 2024
xsuchy
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1475