Return false when comparing different python objects holding the same version tag #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inequality operator of the python ver objects would always return
True if the compared objects were not the actual same python object.
That was leading to situations as
(v := rpm.ver('1.0')) != v # False
rpm.ver('1.0') != rpm.ver('1.0') # True
This commit aims to support the inequality operator among different
python objects that hold the same version the (opposite) way we expect
the equality operator to work. To do so, it adds the PY_NE case to the
tp_richcompare slot function and adds extra checks to a related
rpmpython test case.
Signed-off-by: Beñat Gartzia <[email protected]>
|
Oh, nice catch. I guess I thought/assumed implementing EQ will do the right thing with NE too because .. well, it's just the opposite, right? Guess not. Thanks for the patch! |
|
Yeah, I'd have assumed the same thing actually, that's why it was weird to me to see No problem, thank you for the quick reply! [0] https://peps.python.org/pep-0207/#proposed-resolutions (point 3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While I was working on another issue, I found that the inequality operator of python
rpm.verobjects would not work as I was expecting to.!=would always returnTrueif the compared objects were not the actual same python object. That was leading to situations asI'm not sure whether that was the intended behavior or not. It was not quite what I expected when I tried applying the operator. I didn't research the topic really exhaustively, but I couldn't find related issues at least in the PRs of this repo.
Anyway, this patch adds the
PY_NEcase to thetp_richcompareslot function and adds some extra checks to a related existing test.Thanks for the attention! 😄
cc: @luckyh