Make test image caching saner #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use the single "rpm" tag, it causes multiple build directories to
step on each others' toes, such as when one of them tries to remove the
previous version of the image on a rebuild and falsely assumes that the
"rpm" tag still points to it. That results in an error if that image is
in use by some other build directory, e.g. by a "make shell" session.
Instead, just cache the image ID locally in the build directory which
produced it and use that to refer to the image later. It's like having
a unique tag for each build directory but without polluting the user's
image store with tagged images that are never cleaned up.
Since removing a build directory now means we lose the image ID, delete
the image as soon as we're done using it. Only do that when running
mktree via cmake (the normal case), though, otherwise keep the image so
that one can still use mktree directly to prototype a test without
having to rebuild each time:
./mktree atshell mytest.sh
In that case, the user is expected to clean up the image by themselves
when they're done, of course.
When in CI mode, store the ID in the source tree as we may not have a
build tree.
Sometimes, you may want to use $PODMAN to run your own containers on top of the image (or even base a custom image on it), in which case tagging is actually desired, so add a shorthand for that. Make sure to *not* clean the image if it's tagged, though. Also update the README which still talks about the "rpm" tag.
Base images sometimes used to be pruned as part of a rebuild when they became dangling. That could happen when the "rpm" image was based on a different version of the base image. This was super annoying since you had to wait for the whole package set to be downloaded and installed again. Luckily, base images don't change as often so we can perhaps afford to keep each version around. Do that by simply adding the Dockerfile hash to the tag name.
|
/me pretends to understand and nods agreeably 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in commit messages.