Drop WITH_ARCHIVE remnants + document the dependency
#3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnks
reviewed
Feb 7, 2025
| @@ -1,5 +1,5 @@ | |||
| set(core | |||
| gendiff.1 rpm2cpio.8 | |||
| gendiff.1 rpm2cpio.8 rpm2archive.8 | |||
There was a problem hiding this comment.
Eh, rpm2archive.8 is already in the extra list below.
There was a problem hiding this comment.
I wonder if we should move it to core or keep it there. Probably doesn't matter at all since both lists are joined together anyway 😄
There was a problem hiding this comment.
Oh... except core is actually used to look for enabled plugin material while extra isn't.
There was a problem hiding this comment.
OK, we want this to be in core since extra is used for optional features. Therefore, just drop it from extras and we're good to go.
There was a problem hiding this comment.
Oh, I simply missed the one in extra. Thanks for spotting.
libarchive was made mandatory in 33853c7 but the option was left behind.
dmnks
changed the title
WITH_ARCHIVE remnants + document the dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.