Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3 support #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Python 3 support #14

wants to merge 1 commit into from

Conversation

lights0123
Copy link

Closes #13

Should be compatible with existing Python 2 installations and new Noetic builds

@gmsanchez
Copy link

gmsanchez commented May 25, 2021

Hi! This commit helped to make the reach_ros_node work with ROS Noetic, however the latitude and longitude values are not correct if you live in the south-west hemisphere. I think this code address that issue (worked for me), but I don't know about Python3 and Python2 compatibility.

        latitude = data['latitude']
        if data['latitude_direction'] == str(b'S'):
            latitude = -latitude
        self.msg_fix.latitude = latitude
        longitude = data['longitude']
        if data['longitude_direction'] == str(b'W'):
            longitude = -longitude```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3 support
2 participants