Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles to support using attributes for timeline elements #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update styles to support using attributes for timeline elements #36

wants to merge 2 commits into from

Conversation

walterg2
Copy link

@walterg2 walterg2 commented Aug 8, 2016

Problem

Currently, the style sheet in place has a few places where it is looking for the timeline-* tags instead of relying on CSS classes. This causes users that want to keep their HTML valid issues as they need to duplicate the styles for angular-timeline.

Changes

  • Updated SCSS file to support using attributes
    • Cleaned up the SCSS to take advantage of nested classes
    • Swapped the img style to be nested inside the timeline class so it would not collide with other styles set up by the user
  • Added an example that renders the timeline using only HTML data attributes

Notes

  • Resubmitting this based on the 1.7.0 release
  • I did not include updated ngdocs due to it not correctly interpolating the links
  • Package version was not bumped for this. While I believe this would fall under a revision classification, I felt it best to leave it up to you on how you wanted to update the version

Please let me know if you'd like any changes to what I've done here.

@walterg2
Copy link
Author

walterg2 commented Aug 8, 2016

Hey @rpocklin: Sorry for the long delay in getting back to this... kids and work got extremely busy over the summer.

I've made the fixes you asked for and updated everything to align with the 1.7.0 release. Let me know if you see anything else in here that needs tweaked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant