Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCM Readme & Henridv's FCM Apple Support #664

Closed
wants to merge 10 commits into from
Closed

FCM Readme & Henridv's FCM Apple Support #664

wants to merge 10 commits into from

Conversation

SixiS
Copy link
Contributor

@SixiS SixiS commented Jun 24, 2024

No description provided.

@SixiS SixiS changed the title Henridv's FCM Apple Support & Readme FCM Readme & Henridv's FCM Apple Support Jun 24, 2024
@aried3r
Copy link
Member

aried3r commented Jul 18, 2024

@SixiS, thank you for porting @Henridv's changes to this repo! I've approved the workflow and hope that the tests run successfully. Should older Rails/Ruby versions no longer work, I'm not opposed to drop support for some older versions if that makes sense.

This was referenced Jul 18, 2024
Closed
Merged
@SixiS
Drop Rails 5.2 support.
b84c795 
Move to web-push gem to fix OpenSSL 3.0 error. zaru/webpush#106
Fix various failing tests.
@SixiS
Add appraisal for Rails 7.1
a32077a
@SixiS
Copy link
Contributor Author

SixiS commented Jul 25, 2024 •
edited
Loading

Hey @aried3r

Got the test suite passing on my machine.

Had to replace the webpush with web-push.
zaru/webpush#106 (comment)

Dropped the Rails 5.2 appraisal because it doesn't work with ruby 3 - it's no longer supported, so likely not a problem.
Added an appraisal for Rails 7.1

Needed to bump a few development versions and tweak a few tests, but otherwise no functional changes.

@benlangfeld benlangfeld mentioned this pull request Aug 29, 2024
Merged
benlangfeld pushed a commit that referenced this pull request Aug 29, 2024
@Henridv @benlangfeld
Get test suite working again
5e2762a 
* Drop support for old Ruby/Rails
* Switch to new web-push gem

Credit for much of this goes to @SixiS from #664.

I'm splitting this out so we can consider the FCM Apple support separately from getting master green again.
@benlangfeld benlangfeld mentioned this pull request Aug 29, 2024
Closed
benlangfeld added a commit that referenced this pull request Aug 29, 2024
@benlangfeld @Henridv @SixiS
fcm support v2 (#673)
840125a 
Copy of #664 with some additional
fixes.

Credit to @SixiS and @Henridv.

Closes #670, #664, #662

---------

Co-authored-by: Henri De Veene <[email protected]>
Co-authored-by: Matthew Hirst <[email protected]>
@benlangfeld
Copy link
Collaborator

Superseded by #673. Thanks!

@benlangfeld benlangfeld added this to the 7.1.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SixiS @aried3r @benlangfeld @Henridv