Skip to content

Commit

Permalink
Look for the literal string '127.0.0.1', not the regex '127.0.0.1'
Browse files Browse the repository at this point in the history
In https://buildkite.com/julialang/rr/builds/1638 we saw a test failure due the regex '127.0.0.1' matching 'real_time:25625127.000315'
  • Loading branch information
rocallahan committed Feb 28, 2024
1 parent 0e7aa9d commit 3568db2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/test/tcp_sockets.run
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ cp ${OBJDIR}/bin/$exe $exe-$nonce
just_record $exe-$nonce
# The test binary might fail due to IPv6 being unsupported
EXIT_CODE=$?
if [[ `rr dump --socket-addresses latest-trace|grep --count 127.0.0.1` != 2 ]]; then
if [[ `rr dump --socket-addresses latest-trace|grep --count -F 127.0.0.1` != 2 ]]; then
failed "Wrong number of '127.0.0.1's"
fi
if [[ $EXIT_CODE == 0 ]]; then
if [[ `rr dump --socket-addresses latest-trace|grep --count ::1:` != 2 ]]; then
if [[ `rr dump --socket-addresses latest-trace|grep --count -F ::1:` != 2 ]]; then
failed "Wrong number of '::1:'s"
fi
fi
fi

0 comments on commit 3568db2

Please sign in to comment.