Rename DREQ_SET_MEM to DREQ_SET_MEM_BINARY

We need to be consistent at naming requests with BINARY because there are both binary and hexadecimal versions of some requests.

src/GdbServer.cc

@@ -520,7 +520,7 @@ void GdbServer::dispatch_debugger_request(Session& session,
       dbg->reply_get_mem(mem);
       return;
     }
-    case DREQ_SET_MEM: {
+    case DREQ_SET_MEM_BINARY: {
       // gdb has been observed to send requests of length 0 at
       // odd times
       // (e.g. before sending the magic write to create a checkpoint)

src/GdbServerConnection.cc

@@ -1397,7 +1397,7 @@ bool GdbServerConnection::process_packet() {
       ret = process_vpacket(payload);
       break;
     case 'X': {
-      req = GdbRequest(DREQ_SET_MEM);
+      req = GdbRequest(DREQ_SET_MEM_BINARY);
       req.target = query_thread;
       req.mem().addr = strtoul(payload, &payload, 16);
       parser_assert(',' == *payload++);
@@ -1858,7 +1858,7 @@ void GdbServerConnection::reply_get_mem(const vector<uint8_t>& mem) {
 }
 
 void GdbServerConnection::reply_set_mem(bool ok) {
-  DEBUG_ASSERT(DREQ_SET_MEM == req.type);
+  DEBUG_ASSERT(DREQ_SET_MEM_BINARY == req.type);
 
   write_packet(ok ? "OK" : "E01");
 

src/GdbServerConnection.h

@@ -92,7 +92,7 @@ enum GdbRequestType {
 
   /* These use params.mem. */
   DREQ_GET_MEM,
-  DREQ_SET_MEM,
+  DREQ_SET_MEM_BINARY,
   // gdb wants to read the current siginfo_t for a stopped
   // tracee.  More importantly, this packet arrives at the very
   // beginning of a |call foo()| experiment.