Collect test-failure artifacts

.github/workflows/build-and-test.yml

@@ -20,4 +20,12 @@ jobs:
         run: ./scripts/github-actions-build.sh
 
       - name: Test
+        id: test
         run: ./scripts/github-actions-test.sh
+
+      - uses: actions/upload-artifact@v4
+        if: failure() && steps.test.outcome == 'failure'
+        with:
+          name: failed-tests
+          path: failed-tests/*
+          compression-level: 0

scripts/github-actions-build.sh

@@ -7,7 +7,7 @@ uname -a
 
 EXTRA_PACKAGES=
 MACHINE_TYPE=`uname -m`
-if [ ${MACHINE_TYPE} == 'x86_64' ]; then
+if [ $MACHINE_TYPE == 'x86_64' ]; then
   EXTRA_PACKAGES=g++-multilib
 fi
 

scripts/github-actions-test.sh

@@ -1,7 +1,6 @@
 #!/bin/bash
 
 set +x # echo commands
-set -e # default to exiting on error"
 
 # Enable perf events for rr
 echo 0 | sudo tee /proc/sys/kernel/perf_event_paranoid > /dev/null
@@ -12,3 +11,18 @@ echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope > /dev/null
 let halfproc=`nproc`/2
 cd obj
 ctest -j$halfproc --verbose
+
+STATUS=$?
+if [[ $STATUS != 0 ]]; then
+  mkdir $GITHUB_WORKSPACE/failed-tests
+  cd /tmp
+  rm rr-test-cpu-lock || true
+  for dir in rr-test-*; do
+    echo "Packing test /tmp/$dir"
+    $GITHUB_WORKSPACE/obj/bin/rr pack $dir/latest-trace
+    tar zcf $GITHUB_WORKSPACE/failed-tests/$dir.tar.gz $dir
+    rm -rf $dir
+  done
+fi
+
+exit $STATUS

src/test/prctl.c

@@ -79,6 +79,8 @@ int main(void) {
   test_assert(-1 == prctl(PR_SET_VMA, PR_SET_VMA_ANON_NAME, 0x7000000, page_size, "foo") &&
               (errno == EINVAL || errno == EBADF || errno == ENOMEM));
 
+  return 1;
+
   atomic_puts("EXIT-SUCCESS");
   return 0;
 }