-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter to check if files are mapped in processes not part of the recording. #3419
Add parameter to check if files are mapped in processes not part of the recording. #3419
Conversation
The call to system() might be ugly to dangerous. lsof seems to want in the long term to make it available as library. |
This would be a cool feature to have but rather than calling lsof I think we would want to reimplement the functionality by scanning /proc/.../maps. |
f8cc6dd
to
589b266
Compare
Rebased and removed the ugly lsof system call by manually iterating through /proc/.../maps. |
c1dab11
to
60d34c1
Compare
Rebased and renamed the parameter from --lsof to --check-outside-mmaps. Or is this something we want to activate generally? |
60d34c1
to
559a4f2
Compare
Small addition, return after first process is found with outside mapping and message got printed. Global activation would succeed with the test suite except test mmap_self_maps_shared. |
559a4f2
to
d36beb9
Compare
I made some tests to activate it generally. |
d36beb9
to
fa6ab22
Compare
|
In its current state it just calls lsof with the pids inside the the recording excluded.
It would show the mapping that caused the issue in #3417,
but the others are probably just read-only mappings due to /proc/pid/maps.