DO NOT MERGE #3587
Merged
DO NOT MERGE #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocallahan
force-pushed
the
ignore-bad-stops
branch
6 times, most recently
from
4abb4a7 to
4392bfb
Compare
rocallahan
force-pushed
the
ignore-bad-stops
branch
3 times, most recently
from
8d51a1e to
8eeb8b7
Compare
rocallahan
force-pushed
the
ignore-bad-stops
branch
6 times, most recently
from
5970a88 to
1c9c6d8
Compare
…age, because on new Ubuntus Firefox is a Snap package which we don't support in rr yet
rocallahan
force-pushed
the
ignore-bad-stops
branch
from
1c9c6d8 to
c05c186
Compare
…ematurely exited the stop, just ignore the stop. This makes our state tracking more accurate. Before, when a task is booted out of a ptrace-stop via SIGKILL or equivalent while we're reading its state in `Task::did_waitpid`, we would treat the task as as if it were still stopped, even though now it is either running in the kernel towards PTRACE_EVENT_EXIT or reap, or else stopped in a new PTRACE_EVENT_EXIT stop which we will see in the next wait(). We would cover up the discrepancy by changing the stop to a fake PTRACE_EVENT_EXIT. Instead we now "tell the truth" that the task is not known to be stopped and instead we should wait for its next stop. The downside is that this requires us to propagate the fact that the task is not actually stopped to various callers, including the callers of `Task::resume_execution`. This is annoying, but it's also helpful to consider how these callers should behave when a task is booted out of a ptrace-stop by SIGKILL and is no longer stopped. It's complex and hard to test, but the underlying kernel behavior is the problem.
rocallahan
force-pushed
the
ignore-bad-stops
branch
from
c05c186 to
024064f
Compare
|
I just ran 1000 concurrent instances of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.