Fix block size calculation in dczid_el0_block_size() #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely needs a test case. Could you add an appropriate test in src/test/watchpoint_unaligned.{c,py}? LGTM otherwise. |
DCZID_EL0.BS contains the the log2 of the DC ZVA block size in words (defined as 32 bits), not bytes, so the block size calculation in dczid_el0_block_size() was incorrect. As a result we would sometimes fail to trigger watchpoints. Fix it.
|
Done, but in the process of writing the test I discovered that it looks like there are more arm64-specific watchpoint bugs. |
|
(Filed #3736 for the watchpoint bug I found.) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCZID_EL0.BS contains the the log2 of the DC ZVA block size in words (defined as 32 bits), not bytes, so the block size calculation in dczid_el0_block_size() was incorrect. As a result we would sometimes fail to trigger watchpoints. Fix it.