Fix the condition for watchpoint matching on arm64 #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The language from the ARM manual previously quoted in the comment in fact only pertains to Memory Copy and Memory Set instructions. According to the section describing the behavior for "other instructions", the recorded address can be > the watchpoint address. Therefore, remove the check that the watchpoint address >= the recorded address, and update the comment for accuracy. Fixes rr-debugger#3736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language from the ARM manual previously quoted in the comment in fact only pertains to Memory Copy and Memory Set instructions. According to the section describing the behavior for "other instructions", the recorded address can be > the watchpoint address. Therefore, remove the check that the watchpoint address >= the recorded address, and update the comment for accuracy.
Fixes #3736