Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SIOCGMIIPHY and SIOCGMIIREG ioctls. #3743

Merged
merged 2 commits into from
May 2, 2024

Conversation

bernhardu
Copy link
Contributor

When recording gnome-nettool or mii-tool rr throws assertions like these:

$ bin/rr record /sbin/mii-tool enp7s0
rr: Saving execution to trace directory `/home/bernhard/data/entwicklung/2023/rr/rr-recordings/mii-tool-1'.
[FATAL src/record_syscall.cc:6564:rec_process_syscall_arch()] 
 (task 537273 (rec:537273) at time 139)
 -> Assertion `t->regs().syscall_result_signed() == -syscall_state.expect_errno' failed to hold. Expected EINVAL for 'ioctl' but got result -1 (errno EPERM); Unknown ioctl(0x8947): type:0x89 nr:0x47 dir:0 size:0 addr:0x5607c41203e0
[FATAL src/record_syscall.cc:6565:rec_process_syscall_arch()] 
 (task 596577 (rec:596577) at time 742)
 -> Assertion `t->regs().syscall_result_signed() == -syscall_state.expect_errno' failed to hold. Expected EINVAL for 'ioctl' but got result -1 (errno EPERM); Unknown ioctl(0x8948): type:0x89 nr:0x48 dir:0 size:0 addr:0x7f11cf5defd8

https://github.com/torvalds/linux/blob/0106679839f7c69632b3b9833c3268c316c0a9fc/include/uapi/linux/sockios.h#L104-L106

This two patches are just enough to make rr no longer fail.

@rocallahan rocallahan merged commit 5c06010 into rr-debugger:master May 2, 2024
2 of 4 checks passed
@bernhardu bernhardu deleted the SIOCGMIIPHY branch June 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants