Modifications for old lldb version. #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of lldb seem to have an issue with the `test_setup.lldb` script, or at least the `process handle` commands. Therefore the test hangs because the output does not contain the `received signal: SIGKILL`. lldb version 14.0.6
In old versions of lldb the output format of the `print` command was different, it shows a value history identifier. Therefore the output of `print get_value()` is not recognized in the alternate_thread_diversion test and the test times out. lldb version 14.0.6 'print' is an abbreviation for 'expression --' (rr) print get_value() (int) $0 = 1 lldb version 18.1.3 'print' is an abbreviation for 'dwim-print --' (rr) print get_value() (int) 1
|
This looks good to me. It's reasonably elegant :-) |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received a failure with the new test
alternate_thread_diversionwhen running below my Debian Bookworm system.This not overly elegant modifications would make the test work with this old lldb version.
Another option would be to define a minimum lldb version and check this before running the tests?