Update PerfCounters.cc #3771
Update PerfCounters.cc #3771
Conversation
| @@ -100,6 +100,7 @@ enum CpuMicroarch { | |||
| AMDZen2, | |||
| AMDZen3, | |||
| AMDZen4, | |||
| AMDRyzen9, | |||
There was a problem hiding this comment.
Don't need to add this; this CPU is Zen 4.
There was a problem hiding this comment.
Try it. Not supported. I think we need this line to add the following { AMDRyzen9, "AMD Ryzen 9", 0x5100d1, 0, 0x6F, 10000, PMU_TICKS_RCB | PMU_SKID_UNBOUNDED },
There was a problem hiding this comment.
Why did you put 0x6f there? That's the llsc_cntr_event and it makes no sense to set that for an x86 CPU.
Using Zen4 should work. If it doesn't, something else is quite broken.
There was a problem hiding this comment.
I've just followed the pattern I saw before. After compiling this version it works on my end, so maybe the issue is not fix by my did but was already fixed between the latest package release and the git version?
There was a problem hiding this comment.
Yeah, this change doesn't actually do anything because nothing detects this new architecture type AMDRyzen9..
| @@ -100,6 +100,7 @@ enum CpuMicroarch { | |||
| AMDZen2, | |||
| AMDZen3, | |||
| AMDZen4, | |||
| AMDRyzen9, | |||
There was a problem hiding this comment.
Why did you put 0x6f there? That's the llsc_cntr_event and it makes no sense to set that for an x86 CPU.
Using Zen4 should work. If it doesn't, something else is quite broken.
Fix bug #3770